Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2520293002: Enable syntax-only support for generic functions by default, take 2. (Closed)

Created:
4 years, 1 month ago by eernst
Modified:
4 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable syntax-only support for generic functions by default, take 2. Fixed some status entries since the first land-revert of this CL. This addresses https://github.com/dart-lang/sdk/issues/27501. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/9bf3b95cc5f4677269830054fb5c12b64f1e7f21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 2 chunks +16 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/generic_functions_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_function_type_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_generic_function_parameter_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_new_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_type_expression_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
This was landed as https://codereview.chromium.org/2476423005/, then reverted, and now extended with some status file changes.
4 years, 1 month ago (2016-11-22 10:49:11 UTC) #2
Johnni Winther
lgtm
4 years, 1 month ago (2016-11-22 11:04:58 UTC) #3
eernst
4 years, 1 month ago (2016-11-22 11:33:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9bf3b95cc5f4677269830054fb5c12b64f1e7f21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698