Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2520263002: Check explicitly for style invalidation/recalc in @font-face test. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check explicitly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/b84fb60b526a67365228bc2a4bb6f0005b21a555 Cr-Commit-Position: refs/heads/master@{#434367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
rune
ptal For more context, PS 24 in https://codereview.chromium.org/1913833002/
4 years, 1 month ago (2016-11-22 10:23:39 UTC) #3
meade_UTC10
lgtm
4 years ago (2016-11-24 06:31:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520263002/1
4 years ago (2016-11-24 07:48:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 09:49:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520263002/1
4 years ago (2016-11-24 10:01:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 12:02:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520263002/1
4 years ago (2016-11-24 18:05:34 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 18:45:15 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-24 18:47:31 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b84fb60b526a67365228bc2a4bb6f0005b21a555
Cr-Commit-Position: refs/heads/master@{#434367}

Powered by Google App Engine
This is Rietveld 408576698