Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2520263002:
Check explicitly for style invalidation/recalc in @font-face test. (Closed)
|
Created:
4 years, 1 month ago by rune Modified:
4 years ago Reviewers:
meade_UTC10 CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCheck explicitly for style invalidation/recalc in @font-face test.
needsLayoutTreeUpdate will return true for needing to update the global
ruleset for async style update. Even if the test only tries to add a
@font-face rule, we unconditionally recollect the CSSGlobalRuleSet when
stylesheets are added or removed.
Instead check that adding a @font-face rule in a shadow tree does not
cause style invalidation or recalc.
R=meade@chromium.org
BUG=567021
Committed: https://crrev.com/b84fb60b526a67365228bc2a4bb6f0005b21a555
Cr-Commit-Position: refs/heads/master@{#434367}
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal For more context, PS 24 in https://codereview.chromium.org/1913833002/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Check explictly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 ========== to ========== Check explicitly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 ==========
lgtm
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480010715975710, "parent_rev":
"1b11631df7822adec29fba573368530e62a2c59f", "commit_rev":
"e690e240df2846780f5f37f41974765c420cba88"}
Message was sent while issue was closed.
Description was changed from ========== Check explicitly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 ========== to ========== Check explicitly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Check explicitly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 ========== to ========== Check explicitly for style invalidation/recalc in @font-face test. needsLayoutTreeUpdate will return true for needing to update the global ruleset for async style update. Even if the test only tries to add a @font-face rule, we unconditionally recollect the CSSGlobalRuleSet when stylesheets are added or removed. Instead check that adding a @font-face rule in a shadow tree does not cause style invalidation or recalc. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/b84fb60b526a67365228bc2a4bb6f0005b21a555 Cr-Commit-Position: refs/heads/master@{#434367} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b84fb60b526a67365228bc2a4bb6f0005b21a555 Cr-Commit-Position: refs/heads/master@{#434367} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
