Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 252023003: Revert of Revert of Move service_discovery_client_impl.* into chrome/common. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Revert of Move service_discovery_client_impl.* into chrome/common. (https://codereview.chromium.org/250793011/) Reason for revert: Reland original patch. The revert didn't solve the sizes regression. Original issue's description: > Revert of Move service_discovery_client_impl.* into chrome/common. (https://codereview.chromium.org/256923003/) > > Reason for revert: > [Sheriff] Speculating that this lead to a sizes regression: > https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=266525&checked=core > > Will reland otherwise. > > Original issue's description: > > Move service_discovery_client_impl.* into chrome/common. > > It's need to be used by utility and browser processes. > > > > BUG=349645 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266487 > > TBR=thestig@chromium.org,vitalybuka@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=349645 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266535 TBR=thestig@chromium.org,vitalybuka@chromium.org NOTREECHECKS=true NOTRY=true BUG=349645 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1576 lines, -1575 lines) Patch
D chrome/browser/local_discovery/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/test_service_discovery_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/common/local_discovery/local_domain_resolver_unittest.cc View 1 chunk +183 lines, -0 lines 0 comments Download
A chrome/common/local_discovery/service_discovery_client_impl.h View 1 chunk +273 lines, -0 lines 0 comments Download
A chrome/common/local_discovery/service_discovery_client_impl.cc View 1 chunk +584 lines, -0 lines 0 comments Download
A chrome/common/local_discovery/service_discovery_client_unittest.cc View 1 chunk +518 lines, -0 lines 0 comments Download
M chrome/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/service_discovery_sniffer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/utility/local_discovery/local_domain_resolver_unittest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/utility/local_discovery/service_discovery_client_impl.h View 1 chunk +0 lines, -273 lines 0 comments Download
D chrome/utility/local_discovery/service_discovery_client_impl.cc View 1 chunk +0 lines, -584 lines 0 comments Download
D chrome/utility/local_discovery/service_discovery_client_unittest.cc View 1 chunk +0 lines, -518 lines 0 comments Download
M chrome/utility/local_discovery/service_discovery_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
Created Revert of Revert of Move service_discovery_client_impl.* into chrome/common.
6 years, 7 months ago (2014-04-28 14:03:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/252023003/1
6 years, 7 months ago (2014-04-28 14:03:31 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:18:37 UTC) #3
Message was sent while issue was closed.
Change committed as 266560

Powered by Google App Engine
This is Rietveld 408576698