Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Side by Side Diff: src/mips/code-stubs-mips.cc

Issue 252023002: MIPS: Revert r20974, r20991: Unify and simplify the FastCloneShallowArrayStub. (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 descriptor->deoptimization_handler_ = 75 descriptor->deoptimization_handler_ =
76 Runtime::FunctionForId(Runtime::kHiddenNumberToString)->entry; 76 Runtime::FunctionForId(Runtime::kHiddenNumberToString)->entry;
77 } 77 }
78 78
79 79
80 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor( 80 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor(
81 CodeStubInterfaceDescriptor* descriptor) { 81 CodeStubInterfaceDescriptor* descriptor) {
82 static Register registers[] = { a3, a2, a1 }; 82 static Register registers[] = { a3, a2, a1 };
83 descriptor->register_param_count_ = 3; 83 descriptor->register_param_count_ = 3;
84 descriptor->register_params_ = registers; 84 descriptor->register_params_ = registers;
85 static Representation representations[] = {
86 Representation::Tagged(),
87 Representation::Smi(),
88 Representation::Tagged() };
89 descriptor->register_param_representations_ = representations;
90 descriptor->deoptimization_handler_ = 85 descriptor->deoptimization_handler_ =
91 Runtime::FunctionForId( 86 Runtime::FunctionForId(
92 Runtime::kHiddenCreateArrayLiteralStubBailout)->entry; 87 Runtime::kHiddenCreateArrayLiteralStubBailout)->entry;
93 } 88 }
94 89
95 90
96 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor( 91 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor(
97 CodeStubInterfaceDescriptor* descriptor) { 92 CodeStubInterfaceDescriptor* descriptor) {
98 static Register registers[] = { a3, a2, a1, a0 }; 93 static Register registers[] = { a3, a2, a1, a0 };
99 descriptor->register_param_count_ = 4; 94 descriptor->register_param_count_ = 4;
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 218
224 if (constant_stack_parameter_count == 0) { 219 if (constant_stack_parameter_count == 0) {
225 descriptor->register_param_count_ = 2; 220 descriptor->register_param_count_ = 2;
226 descriptor->register_params_ = registers_no_args; 221 descriptor->register_params_ = registers_no_args;
227 } else { 222 } else {
228 // stack param count needs (constructor pointer, and single argument) 223 // stack param count needs (constructor pointer, and single argument)
229 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS; 224 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS;
230 descriptor->stack_parameter_count_ = a0; 225 descriptor->stack_parameter_count_ = a0;
231 descriptor->register_param_count_ = 3; 226 descriptor->register_param_count_ = 3;
232 descriptor->register_params_ = registers_variable_args; 227 descriptor->register_params_ = registers_variable_args;
233 static Representation representations[] = {
234 Representation::Tagged(),
235 Representation::Tagged(),
236 Representation::Integer32() };
237 descriptor->register_param_representations_ = representations;
238 } 228 }
239 229
240 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count; 230 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count;
241 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE; 231 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE;
242 descriptor->deoptimization_handler_ = 232 descriptor->deoptimization_handler_ =
243 Runtime::FunctionForId(Runtime::kHiddenArrayConstructor)->entry; 233 Runtime::FunctionForId(Runtime::kHiddenArrayConstructor)->entry;
244 } 234 }
245 235
246 236
247 static void InitializeInternalArrayConstructorDescriptor( 237 static void InitializeInternalArrayConstructorDescriptor(
248 CodeStubInterfaceDescriptor* descriptor, 238 CodeStubInterfaceDescriptor* descriptor,
249 int constant_stack_parameter_count) { 239 int constant_stack_parameter_count) {
250 // register state 240 // register state
251 // a0 -- number of arguments 241 // a0 -- number of arguments
252 // a1 -- constructor function 242 // a1 -- constructor function
253 static Register registers_variable_args[] = { a1, a0 }; 243 static Register registers_variable_args[] = { a1, a0 };
254 static Register registers_no_args[] = { a1 }; 244 static Register registers_no_args[] = { a1 };
255 245
256 if (constant_stack_parameter_count == 0) { 246 if (constant_stack_parameter_count == 0) {
257 descriptor->register_param_count_ = 1; 247 descriptor->register_param_count_ = 1;
258 descriptor->register_params_ = registers_no_args; 248 descriptor->register_params_ = registers_no_args;
259 } else { 249 } else {
260 // stack param count needs (constructor pointer, and single argument) 250 // stack param count needs (constructor pointer, and single argument)
261 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS; 251 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS;
262 descriptor->stack_parameter_count_ = a0; 252 descriptor->stack_parameter_count_ = a0;
263 descriptor->register_param_count_ = 2; 253 descriptor->register_param_count_ = 2;
264 descriptor->register_params_ = registers_variable_args; 254 descriptor->register_params_ = registers_variable_args;
265 static Representation representations[] = {
266 Representation::Tagged(),
267 Representation::Integer32() };
268 descriptor->register_param_representations_ = representations;
269 } 255 }
270 256
271 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count; 257 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count;
272 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE; 258 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE;
273 descriptor->deoptimization_handler_ = 259 descriptor->deoptimization_handler_ =
274 Runtime::FunctionForId(Runtime::kHiddenInternalArrayConstructor)->entry; 260 Runtime::FunctionForId(Runtime::kHiddenInternalArrayConstructor)->entry;
275 } 261 }
276 262
277 263
278 void ArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor( 264 void ArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor(
(...skipping 5081 matching lines...) Expand 10 before | Expand all | Expand 10 after
5360 MemOperand(fp, 6 * kPointerSize), 5346 MemOperand(fp, 6 * kPointerSize),
5361 NULL); 5347 NULL);
5362 } 5348 }
5363 5349
5364 5350
5365 #undef __ 5351 #undef __
5366 5352
5367 } } // namespace v8::internal 5353 } } // namespace v8::internal
5368 5354
5369 #endif // V8_TARGET_ARCH_MIPS 5355 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698