runtime/vm/flow_graph_compiler_mips.cc - Issue 2520223003: Remove a dead load and smi untag on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 2520223003: Remove a dead load and smi untag on all platforms. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_mips.cc

diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc

index ef95a0ec6dad85170f04b59d2bee3b3d7ca20f34..fddc90155a504c9929c505a9a83817a57eaceb25 100644

--- a/runtime/vm/flow_graph_compiler_mips.cc

+++ b/runtime/vm/flow_graph_compiler_mips.cc

@@ -808,8 +808,6 @@ void FlowGraphCompiler::CopyParameters() {

}

// Generate code handling each optional parameter in alphabetical order.

__ lw(T1, FieldAddress(S4, ArgumentsDescriptor::count_offset()));

- __ lw(T2, FieldAddress(S4, ArgumentsDescriptor::positional_count_offset()));

- __ SmiUntag(T2);

// Let T1 point to the first passed argument, i.e. to

// fp[kParamEndSlotFromFp + num_args - 0]; num_args (T1) is Smi.

__ sll(T3, T1, 1);

« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »