Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2520223002: Replicate a parsed feature policy representation so it doesn't need to be parsed in the browser pro… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 53e0d94e769a85411bb3d38ba5f7605240fbfa6d..07ecb362b53fcc93f746c3f70240950097161913 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -585,15 +585,19 @@ void FrameLoader::didBeginDocument() {
m_documentLoader->response().httpHeaderField(
HTTPNames::Feature_Policy);
Vector<String> messages;
+ const WebVector<WebFeaturePolicy::ParsedWhitelist>&
+ parsedFeaturePolicyHeaders = FeaturePolicy::parseFeaturePolicy(
+ featurePolicyHeader,
+ m_frame->securityContext()->getSecurityOrigin(), &messages);
m_frame->securityContext()->setFeaturePolicyFromHeader(
- featurePolicyHeader, parentSecurityContext, &messages);
+ parsedFeaturePolicyHeaders, parentSecurityContext);
for (auto& message : messages) {
m_frame->document()->addConsoleMessage(ConsoleMessage::create(
OtherMessageSource, ErrorMessageLevel,
"Error with Feature-Policy header: " + message));
}
- if (client() && !featurePolicyHeader.isEmpty())
- client()->didSetFeaturePolicyHeader(featurePolicyHeader);
+ if (client() && !parsedFeaturePolicyHeaders.isEmpty())
+ client()->didSetFeaturePolicyHeader(parsedFeaturePolicyHeaders);
}
}

Powered by Google App Engine
This is Rietveld 408576698