Replicate a parsed feature policy representation so it doesn't need to be parsed in the browser pro…

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 1751 matching lines @@
   }
 
   std::string old_name = frame_tree_node()->frame_name();
   frame_tree_node()->SetFrameName(name, unique_name);
   if (old_name.empty() && !name.empty())
     frame_tree_node_->render_manager()->CreateProxiesForNewNamedFrame();
   delegate_->DidChangeName(this, name);
 }
 
 void RenderFrameHostImpl::OnDidSetFeaturePolicyHeader(
-    const std::string& header) {
-  frame_tree_node()->SetFeaturePolicyHeader(header);
+    const std::vector<FeaturePolicyParsedWhitelist>& parsed_header) {

[alexmos, 2016/12/01 02:04:19]

nit: I'm curious if we could make the type a bit more readable.  Is "Parsed"
needed in the whitelist class name, or would it be simpler to name it
FeaturePolicyWhitelist, or even just FeatureWhitelist to emphasize that it's a
per-feature whitelist and not per-policy?

Alternatively, maybe you could repeat what you did with WebParsedFeaturePolicy
and define the whole parsed header type as ParsedFeaturePolicy?

[raymes, 2016/12/01 03:03:09]

In blink I was trying to distinguish it from the FeaturePolicy::Whitelist class.
We don't have anything like that in content/ yet but we may have something as we
try to share logic between browser/renderer. So I think it's safer to keep the
FaturePolicyParsedWhitelist name. I can definitely do the typdef you suggest
though.

[alexmos, 2016/12/01 22:27:54]

Acknowledged.

+  frame_tree_node()->SetFeaturePolicyHeader(parsed_header);
 }
 
 void RenderFrameHostImpl::OnDidAddContentSecurityPolicy(
     const ContentSecurityPolicyHeader& header) {
   frame_tree_node()->AddContentSecurityPolicy(header);
 }
 
 void RenderFrameHostImpl::OnEnforceInsecureRequestPolicy(
     blink::WebInsecureRequestPolicy policy) {
   frame_tree_node()->SetInsecureRequestPolicy(policy);
@@ skipping 1554 matching lines @@
   // There is no pending NavigationEntry in these cases, so pass 0 as the
   // pending_nav_entry_id. If the previous handle was a prematurely aborted
   // navigation loaded via LoadDataWithBaseURL, propagate the entry id.
   return NavigationHandleImpl::Create(
       params.url, frame_tree_node_, is_renderer_initiated,
       params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
       entry_id_for_data_nav, false);  // started_from_context_menu
 }
 
 }  // namespace content