Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2520203002: X87: [turbofan] Advance bytecode offset after lazy deopt. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Advance bytecode offset after lazy deopt. port 93c65952009a611b840142e63237c58c7267bfd1 (r40887) original commit message: This changes {FrameState} nodes modeling "after" states to use bytecode offsets pointing to the deoptimizing bytecode. This is in sync with the normal execution, as the bytecode offset is advanced after operations complete in regular bytecode handlers. The change is necessary to ensure lazy deoptimized frames contain an accurate bytecode offset while they are on the stack. Such frames can be inspected by various stack walks. The continuation builtin will advance the bytecode offset upon return. BUG= Committed: https://crrev.com/d135e764dbacc23d45a6ba505b02e1d46f05e3fd Cr-Commit-Position: refs/heads/master@{#41199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/builtins/x87/builtins-x87.cc View 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-22 03:24:06 UTC) #2
chunyang.dai
lgtm
4 years, 1 month ago (2016-11-22 08:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520203002/1
4 years, 1 month ago (2016-11-22 08:09:34 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-22 08:09:35 UTC) #7
Michael Starzinger
LGTM. Thanks!
4 years, 1 month ago (2016-11-22 08:49:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520203002/1
4 years, 1 month ago (2016-11-23 03:17:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-23 03:37:57 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 03:38:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d135e764dbacc23d45a6ba505b02e1d46f05e3fd
Cr-Commit-Position: refs/heads/master@{#41199}

Powered by Google App Engine
This is Rietveld 408576698