Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2520173004: Convert delete-line-003.html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by joone
Modified:
4 years ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert delete-line-003.html to utilize w3c test harness This patch converts the following test to utilize w3c test harness with |assert_selection()| to ease of maintenance for improving code health: LayoutTests/editing/deleting/delete-line-003.html TEST=LayoutTests/editing/deleting/delete-line-003.html Committed: https://crrev.com/56f03f53c9dd7cd2977b6e06dd724f07187124a7 Cr-Commit-Position: refs/heads/master@{#434462}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Just use 'delete' #

Messages

Total messages: 20 (15 generated)
joone
Hi yosin@, I separated the test case change from https://codereview.chromium.org/2517383002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode1725 Please review this CL.
4 years, 1 month ago (2016-11-22 22:45:02 UTC) #4
yosin_UTC9
lgtm w/ nit Note: We don't need to have "[Editing][CodeHealth]" in description. Chromium doesn't use ...
4 years ago (2016-11-24 02:19:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520173004/20001
4 years ago (2016-11-25 08:58:54 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 09:02:53 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-25 09:05:22 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56f03f53c9dd7cd2977b6e06dd724f07187124a7
Cr-Commit-Position: refs/heads/master@{#434462}

Powered by Google App Engine
This is Rietveld 408576698