Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: services/ui/public/interfaces/window_manager.mojom

Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array (Closed)
Patch Set: Use std::move instead of Clone() Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/public/cpp/window_tree_client.cc ('k') | services/ui/ws/event_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index c9d63f81da8d86a0243164be715647c4f4629350..f0e6b4816151c75f547838595ee9317150291acd 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -138,6 +138,11 @@ interface WindowManager {
OnAccelerator(uint32 ack_id, uint32 accelerator_id, ui.mojom.Event event);
};
+struct Accelerator {
+ uint32 id;
+ EventMatcher event_matcher;
+};
+
// This interface is only used as an associated interface and is associated
// with WindowTree.
interface WindowManagerClient {
@@ -159,12 +164,13 @@ interface WindowManagerClient {
// Add and remove accelerators. When accelerators are registered the
// WindowManager receives the event via OnAccelerator() rather than the
// target window. The id is defined by the client and can be used to more
- // easily identify the accelerator's action. If an accelerator with the same
- // id or the same matcher already exists, then the accelerator is not added.
+ // easily identify the accelerator's action.
// Accelerator ids 1 << 31 and above are reserved for internal use.
- //
+
// See WindowTree for details on event dispatch.
- AddAccelerator(uint32 id, EventMatcher matcher) => (bool success);
+ // This ignores any accelerators already defined with the same id or matcher.
+ // Returns true if all accelerators were added successfully.
+ AddAccelerators(array<Accelerator> accelerators) => (bool success);
RemoveAccelerator(uint32 id);
// The window manager has completed a request with the specific change id.
« no previous file with comments | « services/ui/public/cpp/window_tree_client.cc ('k') | services/ui/ws/event_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698