WindowManagerClient::AddAccelerator() should take an array

services/ui/public/interfaces/window_manager.mojom

Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index c9d63f81da8d86a0243164be715647c4f4629350..27ac9862a02a6d476129dee05f3c64d23fcc81c7 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -138,6 +138,12 @@ interface WindowManager {
   OnAccelerator(uint32 ack_id, uint32 accelerator_id, ui.mojom.Event event);
 };
 
+struct Accelerator{
+
+   uint32 id;
+   EventMatcher event_matcher;
+};
+
 // This interface is only used as an associated interface and is associated
 // with WindowTree.
 interface WindowManagerClient {
@@ -156,15 +162,15 @@ interface WindowManagerClient {
                                              int32 y_offset,
                                              gfx.mojom.Insets hit_area);
 
-  // Add and remove accelerators. When accelerators are registered the
-  // WindowManager receives the event via OnAccelerator() rather than the
-  // target window. The id is defined by the client and can be used to more
-  // easily identify the accelerator's action. If an accelerator with the same
-  // id or the same matcher already exists, then the accelerator is not added.
+  // When accelerators are registered, the WindowManager receives the event
+  // via OnAccelerator() rather than the target window. The id is defined by
+  // the client and can be used to more easily identify the accelerator's
+  // action. If an accelerator with the same id or matcher already exists, skip
+  // it. Returns true if all accelerators were added successfully.
+  AddAccelerators(array<Accelerator> accelerators) => (bool success);
+
   // Accelerator ids 1 << 31 and above are reserved for internal use.

[mfomitchev, 2016/12/01 20:51:51]

This comment applies to both Add and Remove, but now it looks like it's specific
to Remove. I'd suggest a different way of organizing: top comment should apply
to both add and remove. You can leave it largerly the same as it was before your
change. Then another comment before AddAccelerators describing its behavior (if
an accelerator with the same id or matcher already exists...).

[thanhph, 2016/12/01 21:26:37]

Done, thanks!

-  //
   // See WindowTree for details on event dispatch.
-  AddAccelerator(uint32 id, EventMatcher matcher) => (bool success);
   RemoveAccelerator(uint32 id);
 
   // The window manager has completed a request with the specific change id.