WindowManagerClient::AddAccelerator() should take an array

services/ui/public/interfaces/window_manager.mojom

Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index c9d63f81da8d86a0243164be715647c4f4629350..2d66e3851422dcc3d96d1a899f54ced9d50224da 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -138,6 +138,11 @@ interface WindowManager {
   OnAccelerator(uint32 ack_id, uint32 accelerator_id, ui.mojom.Event event);
 };
 
+struct Accelerator{

[mfomitchev, 2016/12/01 15:32:36]

nit: space after Accelerator

[thanhph, 2016/12/01 19:03:19]

Done.

[mfomitchev, 2016/12/01 20:51:51]

No, not a blank line. Space. I.e. "Accelerator {"

+   uint32 id;
+   EventMatcher event_matcher;
+};
+
 // This interface is only used as an associated interface and is associated
 // with WindowTree.
 interface WindowManagerClient {
@@ -160,11 +165,12 @@ interface WindowManagerClient {
   // WindowManager receives the event via OnAccelerator() rather than the
   // target window. The id is defined by the client and can be used to more
   // easily identify the accelerator's action. If an accelerator with the same
-  // id or the same matcher already exists, then the accelerator is not added.
+  // id or matcher already exists, skip it.Returns true if all accelerators were

[mfomitchev, 2016/12/01 15:32:36]

Nit: There's some stuff in this comment specific to Add, while most of it
applies to both Add and Remove, which makes the comment a little confusionl. Can
you please clarify which part applies to what. E.g. you can separate the
comments that are specific to AddAccelerators from the
comments that apply to both Add and Remove and put them right before
AddAccelerators method below.

[thanhph, 2016/12/01 19:03:19]

Done.

+  // added successfully.
   // Accelerator ids 1 << 31 and above are reserved for internal use.
   //
   // See WindowTree for details on event dispatch.
-  AddAccelerator(uint32 id, EventMatcher matcher) => (bool success);
+  AddAccelerators(array<Accelerator> accelerators) => (bool success);
   RemoveAccelerator(uint32 id);
 
   // The window manager has completed a request with the specific change id.