WindowManagerClient::AddAccelerator() should take an array

services/ui/public/interfaces/window_manager.mojom

Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index c9d63f81da8d86a0243164be715647c4f4629350..e7a174e02daf417ced694f2ebfb81d7ebd89643a 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -138,6 +138,11 @@ interface WindowManager {
   OnAccelerator(uint32 ack_id, uint32 accelerator_id, ui.mojom.Event event);
 };
 
+struct AcceleratorTransport{

[mfomitchev, 2016/11/29 23:27:41]

Are we appending "Transport" to the struct name in any other mojo structs? If
not, can we just call this Accelerator? E.g. we have gxf::Point and
gfx::mojom::Point. We don't call the point mojo struct
"gfx::mojom::PointTransport". 
If we do this, we should probably also rename CreateAcceleratorTransport to
CreateAccelerator.

[thanhph, 2016/11/30 01:31:20]

The name Accelerator is already used in class ui::Accelerator
https://cs.chromium.org/chromium/src/ui/base/accelerators/accelerator.h?q=Acc...

I rather call it AcceleratorTransport, AcceleratorStruct or some other names to
avoid confusion.

[mfomitchev, 2016/11/30 02:33:04]

Yes, just like gfx::mojom::Point and gfx::Point. There's a ton mojo structs like
this who have counterparts with the same name in different namespaces, so this
shouldn't be confusing. At least as long as they represent the same thing, just
in different contexts (which they do). As a side node, there's also an
Accelerator in ui::ws:
https://cs.chromium.org/chromium/src/services/ui/ws/accelerator.h.

[thanhph, 2016/11/30 14:24:51]

Done, thanks!

+   uint32 id;
+   EventMatcher event_matcher;
+};
+
 // This interface is only used as an associated interface and is associated
 // with WindowTree.
 interface WindowManagerClient {
@@ -160,11 +165,12 @@ interface WindowManagerClient {
   // WindowManager receives the event via OnAccelerator() rather than the
   // target window. The id is defined by the client and can be used to more
   // easily identify the accelerator's action. If an accelerator with the same
-  // id or the same matcher already exists, then the accelerator is not added.
+  // id or matcher already exists, skip it.Returns true if all accelerators were
+  // added successfully.
   // Accelerator ids 1 << 31 and above are reserved for internal use.
   //
   // See WindowTree for details on event dispatch.
-  AddAccelerator(uint32 id, EventMatcher matcher) => (bool success);
+  AddAccelerators(array<AcceleratorTransport> accelerators) => (bool success);
   RemoveAccelerator(uint32 id);
 
   // The window manager has completed a request with the specific change id.