services/ui/ws/window_tree.h - Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/ws/window_tree.h

Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array (Closed)

Patch Set: Modify helper to return vector and leverage helper in other files.Rename/format code. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/ws/window_tree.h

diff --git a/services/ui/ws/window_tree.h b/services/ui/ws/window_tree.h

index 1d304b8adb5d7c3f38131b2668d34dca73d5ec19..91955562d90f2e7fc19b97a40bd8c9c6bdd175d6 100644

--- a/services/ui/ws/window_tree.h

+++ b/services/ui/ws/window_tree.h

@@ -467,9 +467,8 @@ class WindowTree : public mojom::WindowTree,

void CancelWindowMove(Id window_id) override;

// mojom::WindowManagerClient:

- void AddAccelerator(uint32_t id,

- mojom::EventMatcherPtr event_matcher,

- const AddAcceleratorCallback& callback) override;

+ void AddAccelerators(std::vector<mojom::AcceleratorTransportPtr> accelerators,

+ const AddAcceleratorsCallback& callback) override;

void RemoveAccelerator(uint32_t id) override;

void AddActivationParent(Id transport_window_id) override;

void RemoveActivationParent(Id transport_window_id) override;