Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: services/ui/ws/event_dispatcher.h

Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array (Closed)
Patch Set: Modify helper to return vector and leverage helper in other files.Rename/format code. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/event_dispatcher.h
diff --git a/services/ui/ws/event_dispatcher.h b/services/ui/ws/event_dispatcher.h
index 472a0c0e4038d6c0c1af45c7125ee3e1b876985e..c78a2b0a5ce9d8d33915391c0d0ac315fdd9dd21 100644
--- a/services/ui/ws/event_dispatcher.h
+++ b/services/ui/ws/event_dispatcher.h
@@ -15,6 +15,7 @@
#include "services/ui/common/types.h"
#include "services/ui/public/interfaces/cursor.mojom.h"
#include "services/ui/public/interfaces/event_matcher.mojom.h"
mfomitchev 2016/11/29 01:55:46 remove
thanhph 2016/11/29 16:50:17 Done.
+#include "services/ui/public/interfaces/window_manager.mojom.h"
#include "services/ui/ws/drag_cursor_updater.h"
#include "services/ui/ws/modal_window_controller.h"
#include "services/ui/ws/server_window_observer.h"
@@ -122,10 +123,12 @@ class EventDispatcher : public ServerWindowObserver, public DragCursorUpdater {
// ServerWindow* under it.
void UpdateCursorProviderByLastKnownLocation();
- // Adds an accelerator with the given id and event-matcher. If an accelerator
- // already exists with the same id or the same matcher, then the accelerator
- // is not added. Returns whether adding the accelerator was successful or not.
- bool AddAccelerator(uint32_t id, mojom::EventMatcherPtr event_matcher);
+ // iterating through all accelerators, if an accelerator with the same id
mfomitchev 2016/11/29 01:55:46 Adds the supplied accelerators. If an accelerator
thanhph 2016/11/29 16:50:17 Done.
+ // or matcher already exists, skip it and function will return false at the
+ // end of iteration. Function returns true if none of the accelerators exists.
+ bool AddAccelerators(
+ std::vector<ui::mojom::AcceleratorTransportPtr> accelerators);
+
void RemoveAccelerator(uint32_t id);
// Processes the supplied event, informing the delegate as approriate. This

Powered by Google App Engine
This is Rietveld 408576698