Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: services/ui/ws/window_manager_state_unittest.cc

Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array (Closed)
Patch Set: Create anonymous namespace helper for AcceleratorTransport mojom struct. Cleanup/format codes. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/ws/window_manager_state.h" 5 #include "services/ui/ws/window_manager_state.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 child_window->SetVisible(true); 224 child_window->SetVisible(true);
225 SetCanFocusUp(child_window); 225 SetCanFocusUp(child_window);
226 tree()->GetDisplay(child_window)->AddActivationParent(child_window->parent()); 226 tree()->GetDisplay(child_window)->AddActivationParent(child_window->parent());
227 ASSERT_TRUE(window_tree()->SetFocus(child_window_id)); 227 ASSERT_TRUE(window_tree()->SetFocus(child_window_id));
228 228
229 // Register a pre-accelerator. 229 // Register a pre-accelerator.
230 uint32_t accelerator_id = 11; 230 uint32_t accelerator_id = 11;
231 { 231 {
232 mojom::EventMatcherPtr matcher = ui::CreateKeyMatcher( 232 mojom::EventMatcherPtr matcher = ui::CreateKeyMatcher(
233 ui::mojom::KeyboardCode::W, ui::mojom::kEventFlagControlDown); 233 ui::mojom::KeyboardCode::W, ui::mojom::kEventFlagControlDown);
234 ASSERT_TRUE(window_manager_state()->event_dispatcher()->AddAccelerator( 234
235 accelerator_id, std::move(matcher))); 235 ui::mojom::AcceleratorTransportPtr accelerator_transport(
236 ui::mojom::AcceleratorTransport::New());
237 accelerator_transport->id = accelerator_id;
238 accelerator_transport->event_matcher = std::move(matcher);
239
240 std::vector<ui::mojom::AcceleratorTransportPtr> multi_accelerators;
241 multi_accelerators.push_back(std::move(accelerator_transport));
242 ASSERT_TRUE(window_manager_state()->event_dispatcher()->AddAccelerators(
243 std::move(multi_accelerators)));
236 } 244 }
237 TestChangeTracker* tracker = wm_client()->tracker(); 245 TestChangeTracker* tracker = wm_client()->tracker();
238 tracker->changes()->clear(); 246 tracker->changes()->clear();
239 TestChangeTracker* tracker2 = window_tree_client()->tracker(); 247 TestChangeTracker* tracker2 = window_tree_client()->tracker();
240 tracker2->changes()->clear(); 248 tracker2->changes()->clear();
241 249
242 // Send an ensure only the pre accelerator is called. 250 // Send an ensure only the pre accelerator is called.
243 ui::KeyEvent key(ui::ET_KEY_PRESSED, ui::VKEY_W, ui::EF_CONTROL_DOWN); 251 ui::KeyEvent key(ui::ET_KEY_PRESSED, ui::VKEY_W, ui::EF_CONTROL_DOWN);
244 window_manager_state()->ProcessEvent(key); 252 window_manager_state()->ProcessEvent(key);
245 EXPECT_TRUE(window_manager()->on_accelerator_called()); 253 EXPECT_TRUE(window_manager()->on_accelerator_called());
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 ASSERT_EQ(1u, tree->roots().size()); 570 ASSERT_EQ(1u, tree->roots().size());
563 ClientWindowId root_client_id; 571 ClientWindowId root_client_id;
564 ASSERT_TRUE(tree->IsWindowKnown(*(tree->roots().begin()), &root_client_id)); 572 ASSERT_TRUE(tree->IsWindowKnown(*(tree->roots().begin()), &root_client_id));
565 EXPECT_TRUE(tree->DeleteWindow(root_client_id)); 573 EXPECT_TRUE(tree->DeleteWindow(root_client_id));
566 window_server->DestroyTree(tree); 574 window_server->DestroyTree(tree);
567 } 575 }
568 576
569 } // namespace test 577 } // namespace test
570 } // namespace ws 578 } // namespace ws
571 } // namespace ui 579 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698