handle antialiased rendering as premultiplied

handle antialiased rendering as premultiplied

Transparencies and bitmap patterns need to be
unpremultiplied after Skia renders them so
that PDFium can use its own compositing.

Also added some linear (i.e. axial) gradient
support, although its unclear if any of the
test corpus uses this feature.

R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/687fbde2e4ee13637cb3fd9b1fec39a436ef73d7

[caryclark, 2016-11-21 21:20:21]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 21:20:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-11-21 21:29:31]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 21:29:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 21:50:54]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-21 22:01:49]

lgtm w/ nit.

https://codereview.chromium.org/2520073003/diff/20001/core/fxge/skia/fx_skia_...
File core/fxge/skia/fx_skia_device.cpp (right):

https://codereview.chromium.org/2520073003/diff/20001/core/fxge/skia/fx_skia_...
core/fxge/skia/fx_skia_device.cpp:1896: if (!this->IsMarkedForUnPreMultiply())
Drop the this-> as it isn't needed.

[caryclark, 2016-11-22 19:38:57]

Description was changed from

==========
handle antialiased rendering as premultiplied

Transparencies and bitmap patterns need to be
unpremultiplied after Skia renders them so
that PDFium can use its own compositing.

R=dsinclair@chromium.org
==========

to

==========
handle antialiased rendering as premultiplied

Transparencies and bitmap patterns need to be
unpremultiplied after Skia renders them so
that PDFium can use its own compositing.

Also added some linear (i.e. axial) gradient
support, although its unclear if any of the
test corpus uses this feature.

R=dsinclair@chromium.org
==========

[caryclark, 2016-11-22 19:40:50]

On 2016/11/21 22:01:49, dsinclair wrote:
> lgtm w/ nit.
> 
>
https://codereview.chromium.org/2520073003/diff/20001/core/fxge/skia/fx_skia_...
> File core/fxge/skia/fx_skia_device.cpp (right):
> 
>
https://codereview.chromium.org/2520073003/diff/20001/core/fxge/skia/fx_skia_...
> core/fxge/skia/fx_skia_device.cpp:1896: if (!this->IsMarkedForUnPreMultiply())
> Drop the this-> as it isn't needed.

Fixed (in that that line has bee deleted), although I'm unclear what the style
rule is here.

In general, I underestimated the extent to which I would need to clean up for
premultiply vs.
unpremultiply. The CL above looks good in all of the corpus, but as I alluded to
above, I fear
it isn't representative.

[caryclark, 2016-11-22 20:12:43]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 20:12:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 20:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 20:24:43]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-22 20:44:02]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-22 20:44:03]

lgtm

[commit-bot: I haz the power, 2016-11-22 20:44:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 20:44:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479847442898950,
"parent_rev": "89a2d92549d25df6786d53de5671eb141e1fd3e2", "commit_rev":
"687fbde2e4ee13637cb3fd9b1fec39a436ef73d7"}

[commit-bot: I haz the power, 2016-11-22 20:44:28]

Description was changed from

==========
handle antialiased rendering as premultiplied

Transparencies and bitmap patterns need to be
unpremultiplied after Skia renders them so
that PDFium can use its own compositing.

Also added some linear (i.e. axial) gradient
support, although its unclear if any of the
test corpus uses this feature.

R=dsinclair@chromium.org
==========

to

==========
handle antialiased rendering as premultiplied

Transparencies and bitmap patterns need to be
unpremultiplied after Skia renders them so
that PDFium can use its own compositing.

Also added some linear (i.e. axial) gradient
support, although its unclear if any of the
test corpus uses this feature.

R=dsinclair@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/687fbde2e4ee13637cb3fd9b1fec39a436ef...
==========

[commit-bot: I haz the power, 2016-11-22 20:44:29]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/687fbde2e4ee13637cb3fd9b1fec39a436ef...