Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/unicode-decoder.h

Issue 2520053003: Fix out-of-range access in unibrow::Utf8::CalculateValue. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/unicode.cc ('K') | « src/unicode.cc ('k') | test/unittests/BUILD.gn » ('j') | test/unittests/unicode-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/unicode-decoder.h
diff --git a/src/unicode-decoder.h b/src/unicode-decoder.h
index c03084116603c5db734f1d471e25fa92e1106623..35d23a2ac7c0858773bf4dd2bed1bf3285aed430 100644
--- a/src/unicode-decoder.h
+++ b/src/unicode-decoder.h
@@ -7,10 +7,11 @@
#include <sys/types.h>
#include "src/globals.h"
+#include "src/utils.h"
jbroman 2016/11/22 00:25:04 MemCopy is used in this file.
namespace unibrow {
-class Utf8DecoderBase {
+class V8_EXPORT_PRIVATE Utf8DecoderBase {
jbroman 2016/11/22 00:25:04 Allows unicode-unittest.cc to directly use this.
public:
// Initialization done in subclass.
inline Utf8DecoderBase();
« src/unicode.cc ('K') | « src/unicode.cc ('k') | test/unittests/BUILD.gn » ('j') | test/unittests/unicode-unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698