Make extension installation work when the "ask for destination

chrome/browser/download/download_manager.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_manager.h"
 
 #include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 548 matching lines @@
 // insert the new DownloadItem into 'downloads_' or inform our observers at this
 // point. OnCreateDatabaseEntryComplete() handles that finalization of the the
 // download creation as a callback from the history thread.
 void DownloadManager::StartDownload(DownloadCreateInfo* info) {
   DCHECK(MessageLoop::current() == ui_loop_);
   DCHECK(info);
 
   // Freeze the user's preference for showing a Save As dialog.  We're going to
   // bounce around a bunch of threads and we don't want to worry about race
   // conditions where the user changes this pref out from under us.
-  if (*prompt_for_download_)
-    info->save_as = true;
+  if (*prompt_for_download_) {
+    // But never obey the preference for extension installation. Note that we
+    // only care here about the case where an extension is installed, not when
+    // one is downloaded with "save as...".
+    if (!IsExtensionInstall(info))
+      info->save_as = true;
+  }
 
   // Determine the proper path for a download, by choosing either the default
   // download directory, or prompting the user.
   FilePath generated_name;
   GenerateFilename(info, &generated_name);
   if (info->save_as && !last_download_path_.empty())
     info->suggested_path = last_download_path_;
   else
     info->suggested_path = download_path();
   info->suggested_path = info->suggested_path.Append(generated_name);
@@ skipping 965 matching lines @@
 
   if (contents)
     contents->OnStartDownload(download);
 }
 
 // Clears the last download path, used to initialize "save as" dialogs.
 void DownloadManager::ClearLastDownloadPath() {
   last_download_path_ = FilePath();
 }