Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2520043003: Handle nullptr from asTextureRef (Closed)

Created:
4 years, 1 month ago by Brian Osman
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Handle nullptr from asTextureRef This can fail, if the special image dimensions are larger than the maximum allowable render target dimensions. BUG=chromium:666519 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2520043003 Committed: https://skia.googlesource.com/skia/+/818d8a99e8484db29c71cc509dc1969cc786ffd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/image/SkImage.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Brian Osman
I *think* this is the root cause of the fuzz crash.
4 years, 1 month ago (2016-11-22 18:46:00 UTC) #5
bsalomon
lgtm
4 years, 1 month ago (2016-11-22 19:17:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520043003/1
4 years, 1 month ago (2016-11-22 19:23:40 UTC) #9
robertphillips
lgtm
4 years, 1 month ago (2016-11-22 19:26:32 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 20:03:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/818d8a99e8484db29c71cc509dc1969cc786ffd1

Powered by Google App Engine
This is Rietveld 408576698