Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2520043002: add test, fixes #27808: void return type can subtype dynamic (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
vsm, Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add test, fixes #27808: void return type can subtype dynamic this appears to already by implemented R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/a4760b2fd123d9eebf29be430462f7f84b7db292

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : Merge remote-tracking branch 'origin/master' into 27808_void_dyn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 1 month ago (2016-11-21 19:43:55 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-21 20:10:25 UTC) #3
Jennifer Messerly
4 years, 1 month ago (2016-11-21 21:27:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a4760b2fd123d9eebf29be430462f7f84b7db292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698