Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2520033005: MockDataChannelImpl: Implement new interface methods as NOTIMPLEMENTED() (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MockDataChannelImpl: Implement new interface methods as NOTIMPLEMENTED() See https://cs.chromium.org/chromium/src/third_party/webrtc/api/datachannelinterface.h?q=datachannelinterface.h&sq=package:chromium&dr=CSs&l=128 This mock does not need them. This allows us to remove the dummy default implementation of these methods in the webrtc repo. BUG=654927 Committed: https://crrev.com/93aae6e1386ac18f2859aaa4a8558946fbd6cc39 Cr-Commit-Position: refs/heads/master@{#434244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/renderer/media/mock_data_channel_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/mock_data_channel_impl.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
hbos_chromium
Please take a look, guidou.
4 years ago (2016-11-23 16:03:14 UTC) #6
Guido Urdaneta
lgtm
4 years ago (2016-11-23 16:04:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520033005/1
4 years ago (2016-11-23 16:06:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/343489)
4 years ago (2016-11-23 17:08:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520033005/1
4 years ago (2016-11-23 19:50:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 20:54:46 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-23 20:58:14 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93aae6e1386ac18f2859aaa4a8558946fbd6cc39
Cr-Commit-Position: refs/heads/master@{#434244}

Powered by Google App Engine
This is Rietveld 408576698