Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2520013002: Reland of Extracting placeholder information from Webkit to Blimp (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Extracting placeholder information from Webkit to Blimp (patchset #1 id:1 of https://codereview.chromium.org/2513333002/ ) Reason for revert: The revert did not fix the problem, so I'm relanding this now. See also crbug.com/667147. Original issue's description: > Revert of Extracting placeholder information from Webkit to Blimp (patchset #15 id:280001 of https://codereview.chromium.org/2370393002/ ) > > Reason for revert: > I'm speculatively reverting this to see if it causes the failure in blink_platform_unittests noted in https://crbug.com/667094 and as seen in > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20123 > > . It's not at all obvious to my why this would cause that failure, but it's not obvious to me what other changes would've, either, unless maybe it was pdr's change (which I will try if this doesn't fix it). > > Original issue's description: > > Extracting placeholder information from Webkit to Blimp > > > > For text input, the new Blimp IME requires few additional information > > associated with the text field such as label and placeholder attributes. > > For a mock UI, visit go/blimp-type-3 > > > > In this CL, the Blimp tab makes a call to RenderFrameHost to access > > the information about the currently focused text input field and > > supplies a callback to act upon obtaining the information. The > > RenderFrame gets the information, populates it into a FormFieldData > > struct and passes it to the browser which then invokes the supplied > > callback by the embedder. > > > > BUG=651902 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > > > Committed: https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031 > > Cr-Commit-Position: refs/heads/master@{#433364} > > TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=651902 > > Committed: https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320 > Cr-Commit-Position: refs/heads/master@{#433460} TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651902 Committed: https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412 Cr-Commit-Position: refs/heads/master@{#433582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -21 lines) Patch
M blimp/engine/feature/engine_render_widget_feature.h View 2 chunks +2 lines, -1 line 0 comments Download
M blimp/engine/feature/engine_render_widget_feature.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M blimp/engine/feature/engine_render_widget_feature_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M blimp/engine/session/tab.h View 3 chunks +14 lines, -0 lines 0 comments Download
M blimp/engine/session/tab.cc View 3 chunks +39 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 4 chunks +99 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 5 chunks +27 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 4 chunks +17 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/common/form_field_data.h View 1 chunk +28 lines, -0 lines 0 comments Download
A content/public/common/form_field_data.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Dirk Pranke
Created Reland of Extracting placeholder information from Webkit to Blimp
4 years, 1 month ago (2016-11-21 17:44:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520013002/1
4 years, 1 month ago (2016-11-21 17:44:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 17:46:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412 Cr-Commit-Position: refs/heads/master@{#433582}
4 years, 1 month ago (2016-11-21 17:47:52 UTC) #8
tkent
4 years, 1 month ago (2016-11-22 00:29:20 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698