Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2520003007:
[Mac] Omnibox text and icon spacing (Closed)
Description[Mac] Omnibox text and icon spacing
- Moved the BubbleDecoration one pt to the left
- Moved the Omnibox text one pt to the left
BUG=666990, 666977
Committed: https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390
Cr-Commit-Position: refs/heads/master@{#434929}
Patch Set 1 #Patch Set 2 : Adjustment #
Messages
Total messages: 30 (17 generated)
Description was changed from ========== [Mac] Omnibox text and icon spacing - Moved the bubble decoration a couple BUG= ========== to ========== [Mac] Omnibox text and icon spacing - Moved the bubble decoration a couple BUG= 666990 ==========
Description was changed from ========== [Mac] Omnibox text and icon spacing - Moved the bubble decoration a couple BUG= 666990 ========== to ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text 2 pts to the left BUG=666990, 666977 ==========
spqchan@chromium.org changed reviewers: + shrike@chromium.org
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/23 01:08:59, spqchan wrote: > PTAL ping
On 2016/11/28 22:38:21, spqchan wrote: > On 2016/11/23 01:08:59, spqchan wrote: > > PTAL > > ping (Sorry for the rush since you just got back. I just want to try to get this in by tomorrow since this is a Beta blocker)
On 2016/11/28 22:56:42, spqchan wrote: > > (Sorry for the rush since you just got back. I just want to try to get this in > by tomorrow since this is a Beta blocker) Hello spqchan@, Testing on my non-Retina desktop machine, the position of the magnifier looks good. However, it now looks like the omnibox text is pt too far to the left. I will attach a screenshot to the bug.
Description was changed from ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text 2 pts to the left BUG=666990, 666977 ========== to ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG=666990, 666977 ==========
On 2016/11/29 01:06:38, shrike wrote: > On 2016/11/28 22:56:42, spqchan wrote: > > > > (Sorry for the rush since you just got back. I just want to try to get this in > > by tomorrow since this is a Beta blocker) > > Hello spqchan@, > > Testing on my non-Retina desktop machine, the position of the magnifier looks > good. However, it now looks like the omnibox text is pt too far to the left. I > will attach a screenshot to the bug. Thanks for checking! I changed the value so the text is now shifted only 1 pt to the left. WYDT?
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/29 01:25:47, spqchan wrote: > Thanks for checking! I changed the value so the text is now shifted only 1 pt to > the left. WYDT? lgtm - the text is lining up now.
On 2016/11/29 01:31:20, shrike wrote: > On 2016/11/29 01:25:47, spqchan wrote: > > Thanks for checking! I changed the value so the text is now shifted only 1 pt > to > > the left. WYDT? > > lgtm - the text is lining up now. Awesome, thanks!
spqchan@chromium.org changed reviewers: + avi@chromium.org
+avi for ownership
lgtm stamp
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/29 01:58:41, Avi wrote: > lgtm > > stamp thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480406652058870,
"parent_rev": "0ddf602a6d65de8743e1468b8dd8210643120b8e", "commit_rev":
"ca070b9ef397c4be6a5ed2d2ac383c2df0469e3b"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG=666990, 666977 ========== to ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG=666990, 666977 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG=666990, 666977 ========== to ========== [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG=666990, 666977 Committed: https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390 Cr-Commit-Position: refs/heads/master@{#434929} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390 Cr-Commit-Position: refs/heads/master@{#434929} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
