Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2520003006: [Devtools] Fix hover issue with darktheme in network (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fix hover issue with darktheme in network This patch fixes dark theme hover issues with dark theme due to TimelineGrid.js having fixed height for the header draw area. See: http://imgur.com/a/mWpZu R=dgozman,lushnikov BUG=667170 Committed: https://crrev.com/f763518adae729c9fc7296494d7468eee061f519 Cr-Commit-Position: refs/heads/master@{#434092}

Patch Set 1 #

Patch Set 2 : [Devtools] Fix hover issue with darktheme in network #

Total comments: 2

Patch Set 3 : [Devtools] Fix hover issue with darktheme in network #

Patch Set 4 : [Devtools] Fix hover issue with darktheme in network #

Messages

Total messages: 12 (6 generated)
allada
PTL
4 years, 1 month ago (2016-11-22 22:54:24 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2520003006/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js (right): https://codereview.chromium.org/2520003006/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js#newcode305 third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:305: context.save(); You don't need context.save / context.restore - ...
4 years, 1 month ago (2016-11-23 00:16:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520003006/60001
4 years, 1 month ago (2016-11-23 00:56:36 UTC) #7
allada
done https://codereview.chromium.org/2520003006/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js (right): https://codereview.chromium.org/2520003006/diff/20001/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js#newcode305 third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:305: context.save(); On 2016/11/23 00:16:34, lushnikov wrote: > You ...
4 years, 1 month ago (2016-11-23 01:06:03 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-23 02:39:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 02:41:14 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f763518adae729c9fc7296494d7468eee061f519
Cr-Commit-Position: refs/heads/master@{#434092}

Powered by Google App Engine
This is Rietveld 408576698