Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2520003004: Add MSA optimized ARGBToRGB565Row_MSA, ARGBToARGB1555Row_MSA, ARGBToARGB4444Row_MSA, ARGBToUV444Row… (Closed)

Created:
4 years, 1 month ago by manojkumar.bhosale
Modified:
4 years, 1 month ago
CC:
gordana.cmiljanovic_imgtec.com, raghu.gandham_imgtec.com, parag.salasakar_imgtec.com, mandar.sahastrabuddhe_imgtec.com, rob.isherwood_imgtec.com
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add MSA optimized ARGBToRGB565Row_MSA, ARGBToARGB1555Row_MSA, ARGBToARGB4444Row_MSA, ARGBToUV444Row_MSA functions R=fbarchard@google.com BUG=libyuv:634 Performance Gain (vs C vectorized) ARGBToRGB565Row_MSA - ~1.6x ARGBToRGB565Row_Any_MSA - ~1.6x ARGBToARGB1555Row_MSA - ~1.3x ARGBToARGB1555Row_Any_MSA - ~1.3x ARGBToARGB4444Row_MSA - ~3.8x ARGBToARGB4444Row_Any_MSA - ~3.8x ARGBToUV444Row_MSA - ~2.4x ARGBToUV444Row_Any_MSA - ~2.4x Performance Gain (vs C non-vectorized) ARGBToRGB565Row_MSA - ~2.8x ARGBToRGB565Row_Any_MSA - ~2.8x ARGBToARGB1555Row_MSA - ~2.2x ARGBToARGB1555Row_Any_MSA - ~2.2x ARGBToARGB4444Row_MSA - ~6.8x ARGBToARGB4444Row_Any_MSA - ~6.6x ARGBToUV444Row_MSA - ~6.7x ARGBToUV444Row_Any_MSA - ~6.7x Committed: https://chromium.googlesource.com/libyuv/libyuv/+/da0c29dada64273a9610c0ace86d7a6382236c7d

Patch Set 1 #

Patch Set 2 : Clang format #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -0 lines) Patch
M include/libyuv/row.h View 1 5 chunks +22 lines, -0 lines 0 comments Download
M source/convert_from_argb.cc View 4 chunks +32 lines, -0 lines 0 comments Download
M source/row_any.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M source/row_msa.cc View 1 1 chunk +169 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
manojkumar.bhosale
4 years, 1 month ago (2016-11-22 10:58:49 UTC) #1
manojkumar.bhosale
Updated with reviewers, cc list and performance gain numbers
4 years, 1 month ago (2016-11-22 11:06:58 UTC) #4
fbarchard1
lgtm https://codereview.chromium.org/2520003004/diff/20001/source/row_msa.cc File source/row_msa.cc (right): https://codereview.chromium.org/2520003004/diff/20001/source/row_msa.cc#newcode896 source/row_msa.cc:896: v8u16 const_112 = (v8u16)__msa_ldi_h(112); note these constants will ...
4 years, 1 month ago (2016-11-22 18:46:16 UTC) #5
fbarchard1
Committed patchset #2 (id:20001) manually as da0c29dada64273a9610c0ace86d7a6382236c7d (presubmit successful).
4 years, 1 month ago (2016-11-22 18:47:58 UTC) #7
fbarchard1
4 years, 1 month ago (2016-11-22 18:48:35 UTC) #8
Message was sent while issue was closed. 
bumped version, ran clang-format and landed as r1635

Powered by Google App Engine
This is Rietveld 408576698