Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2519973004: [turbofan] Regalloc validator: support same block pending assessment (Closed)

Created:
4 years, 1 month ago by Mircea Trofin
Modified:
4 years, 1 month ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Regalloc validator: support same block pending assessment Previous fuzzer fix broke the case when the pending assessment came from the same block. In that case, the assessments table does not have an entry yet for the block, because we register only when we're done processing a block. BUG=667745 Committed: https://crrev.com/7a1ad0c581e1ac5536723fcddbf8e623bd59b1c7 Cr-Commit-Position: refs/heads/master@{#41193}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -1 line) Patch
M src/compiler/register-allocator-verifier.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/wasm/regression-667745.js View 1 chunk +415 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Mircea Trofin
Patch#1 introduces the regression test, Patch#2 fixes the issue.
4 years, 1 month ago (2016-11-22 17:08:15 UTC) #7
bradnelson
lgtm
4 years, 1 month ago (2016-11-22 17:18:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519973004/20001
4 years, 1 month ago (2016-11-22 17:18:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 17:30:59 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:31:12 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a1ad0c581e1ac5536723fcddbf8e623bd59b1c7
Cr-Commit-Position: refs/heads/master@{#41193}

Powered by Google App Engine
This is Rietveld 408576698