Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2519973003: Reland of Use switch-case for CSS delimiter parsing (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
Reviewers:
Timothy Loh, kochi
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use switch-case for CSS delimiter parsing (patchset #1 id:1 of https://codereview.chromium.org/2521043002/ ) Reason for revert: Doesn't look like the revert helped in any way, so relanding Original issue's description: > Revert of Use switch-case for CSS delimiter parsing (patchset #2 id:20001 of https://codereview.chromium.org/2515633002/ ) > > Reason for revert: > Suspected cause for fast/forms/relayout-shifts-inner-editor.html failures. > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6029 > https://bugs.chromium.org/p/chromium/issues/detail?id=667403 > > Original issue's description: > > Use switch-case for CSS delimiter parsing > > > > This is style-only change and should not change any logic/behavior. > > > > Committed: https://crrev.com/87c9635abb27e45f913c174043fc115c088aead5 > > Cr-Commit-Position: refs/heads/master@{#433470} > > TBR=timloh@chromium.org,kochi@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/749322111601d5aef7f4679bde7652535ccbc391 > Cr-Commit-Position: refs/heads/master@{#433599} TBR=timloh@chromium.org,kochi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/93fbcb734e49ba6719be0b926f865b4f944ec665 Cr-Commit-Position: refs/heads/master@{#433676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -40 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +45 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
piman
Created Reland of Use switch-case for CSS delimiter parsing
4 years, 1 month ago (2016-11-21 22:28:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519973003/1
4 years, 1 month ago (2016-11-21 22:29:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 22:30:20 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 22:32:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93fbcb734e49ba6719be0b926f865b4f944ec665
Cr-Commit-Position: refs/heads/master@{#433676}

Powered by Google App Engine
This is Rietveld 408576698