Stop dispatching encoded-data-length on each data chunk arrival

third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 395 matching lines @@
     WebURLRequest::FrameType frameType,
     WebURLRequest::RequestContext requestContext,
     Resource* resource) {
   dispatchDidReceiveResponseInternal(identifier, response, frameType,
                                      requestContext, resource,
                                      LinkLoader::LoadResourcesAndPreconnect);
 }
 
 void FrameFetchContext::dispatchDidReceiveData(unsigned long identifier,
                                                const char* data,
-                                               int dataLength,
-                                               int encodedDataLength) {
+                                               int dataLength) {
+  TRACE_EVENT1("devtools.timeline", "ResourceReceivedData", "data",
+               InspectorReceiveDataEvent::data(identifier, frame(), 0));
+  frame()->loader().progress().incrementProgress(identifier, dataLength);
+  InspectorInstrumentation::didReceiveData(frame(), identifier, data,
+                                           dataLength);
+}
+
+void FrameFetchContext::dispatchDidReceiveEncodedData(unsigned long identifier,
+                                                      int encodedDataLength) {
   TRACE_EVENT1(
       "devtools.timeline", "ResourceReceivedData", "data",
       InspectorReceiveDataEvent::data(identifier, frame(), encodedDataLength));
-  frame()->loader().progress().incrementProgress(identifier, dataLength);
-  InspectorInstrumentation::didReceiveData(frame(), identifier, data,
-                                           dataLength, encodedDataLength);
+  InspectorInstrumentation::didReceiveEncodedData(frame(), identifier,
+                                                  encodedDataLength);
 }
 
 void FrameFetchContext::dispatchDidDownloadData(unsigned long identifier,
                                                 int dataLength,
                                                 int encodedDataLength) {
   TRACE_EVENT1(
       "devtools.timeline", "ResourceReceivedData", "data",
       InspectorReceiveDataEvent::data(identifier, frame(), encodedDataLength));
   frame()->loader().progress().incrementProgress(identifier, dataLength);
-  InspectorInstrumentation::didReceiveData(frame(), identifier, 0, dataLength,
-                                           encodedDataLength);
+  InspectorInstrumentation::didReceiveData(frame(), identifier, 0, dataLength);
+  InspectorInstrumentation::didReceiveEncodedData(frame(), identifier,
+                                                  encodedDataLength);
 }
 
 void FrameFetchContext::dispatchDidFinishLoading(unsigned long identifier,
                                                  double finishTime,
                                                  int64_t encodedDataLength) {
   TRACE_EVENT1(
       "devtools.timeline", "ResourceFinish", "data",
       InspectorResourceFinishEvent::data(identifier, finishTime, false));
   frame()->loader().progress().completeProgress(identifier);
   InspectorInstrumentation::didFinishLoading(frame(), identifier, finishTime,
                                              encodedDataLength);
   if (frame()->frameScheduler())
     frame()->frameScheduler()->didStopLoading(identifier);
 }
 
 void FrameFetchContext::dispatchDidFail(unsigned long identifier,
                                         const ResourceError& error,
+                                        int64_t encodedDataLength,

[dgozman, 2016/11/30 18:02:17]

Why pass this if it's unused?

[yhirano, 2016/12/01 10:33:10]

For consistency.

                                         bool isInternalRequest) {
   TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
                InspectorResourceFinishEvent::data(identifier, 0, true));
   frame()->loader().progress().completeProgress(identifier);
   InspectorInstrumentation::didFailLoading(frame(), identifier, error);
   // Notification to FrameConsole should come AFTER InspectorInstrumentation
   // call, DevTools front-end relies on this.
   if (!isInternalRequest)
     frame()->console().didFailLoading(identifier, error);
   if (frame()->frameScheduler())
@@ skipping 14 matching lines @@
                           resource->options().initiatorInfo);
 
   InspectorInstrumentation::markResourceAsCached(frame(), identifier);
   if (!resource->response().isNull()) {
     dispatchDidReceiveResponseInternal(identifier, resource->response(),
                                        frameType, requestContext, resource,
                                        LinkLoader::DoNotLoadResources);
   }
 
   if (resource->encodedSize() > 0)
-    dispatchDidReceiveData(identifier, 0, resource->encodedSize(), 0);
+    dispatchDidReceiveData(identifier, 0, resource->encodedSize());
 
   dispatchDidFinishLoading(identifier, 0, 0);
 }
 
 bool FrameFetchContext::shouldLoadNewResource(Resource::Type type) const {
   if (!m_documentLoader)
     return true;
   if (type == Resource::MainResource)
     return m_documentLoader == frame()->loader().provisionalDocumentLoader();
   return m_documentLoader == frame()->loader().documentLoader();
@@ skipping 509 matching lines @@
                                                     response);
 }
 
 DEFINE_TRACE(FrameFetchContext) {
   visitor->trace(m_document);
   visitor->trace(m_documentLoader);
   FetchContext::trace(visitor);
 }
 
 }  // namespace blink