Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2519883002: Update stacktrace_test with negative tests (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -12 lines) Patch
M tests/compiler/dart2js/sourcemaps/stacktrace_test.dart View 11 chunks +78 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-21 10:50:57 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 1 month ago (2016-11-21 16:15:40 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-22 14:47:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a71060355381fc912870a31c2878425b66be36c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698