Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

Issue 2519873004: Set auto breakpoint at various errors (Closed)
Patch Set: Reland Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart
index 0a3e17621e50da77daa92ebd2b7438590d447386..d7d6c5cbc7d5d02e1cfe516b3df9e15f97c6014c 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart
@@ -21,14 +21,20 @@ Iterable getOwnPropertySymbols(obj) =>
final hasOwnProperty = JS('', 'Object.prototype.hasOwnProperty');
+void debugger() {
+ JS('', 'debugger');
+}
+
/// This error indicates a strong mode specific failure, other than a type
/// assertion failure (TypeError) or CastError.
void throwStrongModeError(String message) {
+ debugger();
Jennifer Messerly 2016/11/21 22:16:05 same here, maybe just inline this:" JS('', 'd
vsm 2016/11/21 22:39:25 Done.
JS('', 'throw new #(#);', StrongModeErrorImplementation, message);
}
/// This error indicates a bug in the runtime or the compiler.
void throwInternalError(String message) {
+ debugger();
JS('', 'throw Error(#)', message);
}

Powered by Google App Engine
This is Rietveld 408576698