Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2014)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

Issue 2519873004: Set auto breakpoint at various errors (Closed)
Patch Set: Reland Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart
index 8b7703511741cd8c8d0a68f371b76fe9c892bd0c..fd4333ef1cd2790094c9a700559fada6e4c9f6f3 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart
@@ -4,34 +4,40 @@
part of dart._runtime;
throwCastError(object, actual, type) => JS('', '''(() => {
+ $debugger();
Jennifer Messerly 2016/11/21 22:16:05 since you're already in a JS literal, you don't ne
vsm 2016/11/21 22:39:25 Done.
$throw_(new $CastErrorImplementation($object,
$typeName($actual),
$typeName($type)));
})()''');
throwTypeError(object, actual, type) => JS('', '''(() => {
+ $debugger();
Jennifer Messerly 2016/11/21 22:16:05 same for the rest of these
vsm 2016/11/21 22:39:25 Done.
$throw_(new $TypeErrorImplementation($object,
$typeName($actual),
$typeName($type)));
})()''');
throwStrongModeCastError(object, actual, type) => JS('', '''(() => {
+ $debugger();
$throw_(new $StrongModeCastError($object,
$typeName($actual),
$typeName($type)));
})()''');
throwStrongModeTypeError(object, actual, type) => JS('', '''(() => {
+ $debugger();
$throw_(new $StrongModeTypeError($object,
$typeName($actual),
$typeName($type)));
})()''');
throwUnimplementedError(message) => JS('', '''(() => {
+ $debugger();
$throw_(new $UnimplementedError($message));
})()''');
throwAssertionError() => JS('', '''(() => {
+ $debugger();
$throw_(new $AssertionError());
})()''');
@@ -39,6 +45,7 @@ throwNullValueError() => JS('', '''(() => {
// TODO(vsm): Per spec, we should throw an NSM here. Technically, we ought
// to thread through method info, but that uglifies the code and can't
// actually be queried ... it only affects how the error is printed.
+ $debugger();
$throw_(new $NoSuchMethodError(null,
new $Symbol('<Unexpected Null Value>'), null, null, null));
})()''');

Powered by Google App Engine
This is Rietveld 408576698