Set auto breakpoint at various errors

Set auto breakpoint at various errors

Any reason not to do this?  I generally find when framework code wraps these errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger with the thought of making it configurable.

R=jacobr@google.com, jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/de9e3a30058c829679b912cf060eafe17582b62f

[vsm, 2016-11-21 22:10:13]

Description was changed from

==========
Set auto breakpoint at various errors
==========

to

==========
Set auto breakpoint at various errors

Any reason not to do this?  I generally find when framework code wraps these
errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger
with the thought of making it configurable.
==========

[vsm, 2016-11-21 22:10:13]

vsm@google.com changed reviewers:
+ jacobr@google.com, jmesserly@google.com

[Jennifer Messerly, 2016-11-21 22:16:05]

LGTM

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart (right):

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart:7: $debugger();
since you're already in a JS literal, you don't need a function call, you could
just say "debugger;" right? if we don't parse it yet, easy to fix that in
js_ast.

the benefit to the user is one less stack frame.

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart:14: $debugger();
same for the rest of these

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart (right):

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart:31: debugger();
same here, maybe just inline this:"

    JS('', 'debugger');

that way users get the breakpoint with one less stack frame to jump up.

[vsm, 2016-11-21 22:39:26]

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart (right):

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart:7: $debugger();
On 2016/11/21 22:16:05, Jennifer Messerly wrote:
> since you're already in a JS literal, you don't need a function call, you
could
> just say "debugger;" right? if we don't parse it yet, easy to fix that in
> js_ast.
> 
> the benefit to the user is one less stack frame.

Done.

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart:14: $debugger();
On 2016/11/21 22:16:05, Jennifer Messerly wrote:
> same for the rest of these

Done.

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart (right):

https://codereview.chromium.org/2519873004/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart:31: debugger();
On 2016/11/21 22:16:05, Jennifer Messerly wrote:
> same here, maybe just inline this:"
> 
>     JS('', 'debugger');
> 
> that way users get the breakpoint with one less stack frame to jump up.

Done.

[Jacob, 2016-11-21 22:40:01]

lgtm

[vsm, 2016-11-21 22:40:53]

Description was changed from

==========
Set auto breakpoint at various errors

Any reason not to do this?  I generally find when framework code wraps these
errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger
with the thought of making it configurable.
==========

to

==========
Set auto breakpoint at various errors

Any reason not to do this?  I generally find when framework code wraps these
errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger
with the thought of making it configurable.

R=jacobr@google.com, jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/de9e3a30058c829679b912cf060eafe17582b62f
==========

[vsm, 2016-11-21 22:40:54]

Committed patchset #3 (id:40001) manually as
de9e3a30058c829679b912cf060eafe17582b62f (presubmit successful).