src/IceAssemblerMIPS32.cpp - Issue 2519863002: Subzero, MIPS32: Changes for improving sandbox crosstest results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerMIPS32.cpp

Issue 2519863002: Subzero, MIPS32: Changes for improving sandbox crosstest results (Closed)

Patch Set: Addressed review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceAssemblerMIPS32.cpp

diff --git a/src/IceAssemblerMIPS32.cpp b/src/IceAssemblerMIPS32.cpp

index 2360b9c7a21b40a4f657d17fa5119d875e38a755..a212457cc7f66cfa78b1cf5068c8cd0a0e5690b2 100644

--- a/src/IceAssemblerMIPS32.cpp

+++ b/src/IceAssemblerMIPS32.cpp

@@ -650,7 +650,7 @@ void AssemblerMIPS32::jalr(const Operand *OpRs, const Operand *OpRd) {

const IValueT Rs = encodeGPRegister(OpRs, "Rs", "jalr");

const IValueT Rd =

(OpRd == nullptr) ? 31 : encodeGPRegister(OpRd, "Rd", "jalr");

- Opcode |= Rd << 16;

+ Opcode |= Rd << 11;

Opcode |= Rs << 21;

emitInst(Opcode);

nop();

« no previous file with comments | « pydir/crosstest_generator.py ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »