Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2519853002: [debugger] step-next across yield should not leave the generator. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] step-next across yield should not leave the generator. Stepping in a generator now behaves similar to stepping inside an async function. Stepping in or next at a yield expression will result in a break inside the same generator when we return to the generator. Behavior of step-out does not change. R=jgruber@chromium.org, neis@chromium.org BUG=chromium:496865 Committed: https://crrev.com/416e423fdbf36f65961d36d29e18369b88fe042a Cr-Commit-Position: refs/heads/master@{#41132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -9 lines) Patch
M src/debug/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/debugger/debug/es6/debug-stepin-generators.js View 1 chunk +5 lines, -1 line 0 comments Download
A test/debugger/debug/es6/debug-stepnext-generators.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 1 month ago (2016-11-21 08:55:49 UTC) #1
jgruber
lgtm
4 years, 1 month ago (2016-11-21 09:26:07 UTC) #2
neis
lgtm
4 years, 1 month ago (2016-11-21 10:04:14 UTC) #3
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 1 month ago (2016-11-21 10:04:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519853002/1
4 years, 1 month ago (2016-11-21 10:37:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 11:04:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 11:05:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/416e423fdbf36f65961d36d29e18369b88fe042a
Cr-Commit-Position: refs/heads/master@{#41132}

Powered by Google App Engine
This is Rietveld 408576698