Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 251983002: Rename getSearchTerms as getText (Closed)

Created:
6 years, 7 months ago by Changwan Ryu
Modified:
6 years, 7 months ago
Reviewers:
Ted C, Maria
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ToolbarModel::GetText() returns not only search terms but also formatted URL. Android does not use location_bar_view but its own LocationBarView, and this still requires access to ToolbarModel::GetText() to show formatted URL to its users. We need to reuse GetText() to get formatted URL. BUG=365567, 293227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270027

Patch Set 1 #

Patch Set 2 : fixed comment #

Patch Set 3 : changed to reuse gettext instead #

Total comments: 2

Patch Set 4 : fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Changwan Ryu
6 years, 7 months ago (2014-04-28 08:09:09 UTC) #1
Ted C
lgtm
6 years, 7 months ago (2014-04-28 23:42:40 UTC) #2
Changwan Ryu
6 years, 7 months ago (2014-05-07 00:49:31 UTC) #3
Ted C
https://codereview.chromium.org/251983002/diff/40001/chrome/browser/ui/android/toolbar/toolbar_model_android.cc File chrome/browser/ui/android/toolbar/toolbar_model_android.cc (right): https://codereview.chromium.org/251983002/diff/40001/chrome/browser/ui/android/toolbar/toolbar_model_android.cc#newcode30 chrome/browser/ui/android/toolbar/toolbar_model_android.cc:30: jobject obj) { Just noticed the indenting of this ...
6 years, 7 months ago (2014-05-12 20:16:38 UTC) #4
Changwan Ryu
https://codereview.chromium.org/251983002/diff/40001/chrome/browser/ui/android/toolbar/toolbar_model_android.cc File chrome/browser/ui/android/toolbar/toolbar_model_android.cc (right): https://codereview.chromium.org/251983002/diff/40001/chrome/browser/ui/android/toolbar/toolbar_model_android.cc#newcode30 chrome/browser/ui/android/toolbar/toolbar_model_android.cc:30: jobject obj) { On 2014/05/12 20:16:39, Ted C wrote: ...
6 years, 7 months ago (2014-05-13 01:27:39 UTC) #5
Changwan Ryu
The CQ bit was checked by changwan@chromium.org
6 years, 7 months ago (2014-05-13 01:32:01 UTC) #6
Changwan Ryu
The CQ bit was unchecked by changwan@chromium.org
6 years, 7 months ago (2014-05-13 01:32:05 UTC) #7
Changwan Ryu
The CQ bit was checked by changwan@chromium.org
6 years, 7 months ago (2014-05-13 01:35:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/changwan@chromium.org/251983002/60001
6 years, 7 months ago (2014-05-13 01:37:33 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 05:16:49 UTC) #10
Message was sent while issue was closed.
Change committed as 270027

Powered by Google App Engine
This is Rietveld 408576698