Make generate_perf_json.py work regardless of starting working directory

Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.

BUG=667435
Committed: https://crrev.com/83e8ca3114f774182150be1bd2e4d85fd0b2c7ec
Cr-Commit-Position: refs/heads/master@{#434166}

[alancutter (OOO until 2018), 2016-11-21 00:56:46]

alancutter@chromium.org changed reviewers:
+ dtu@chromium.org

[sullivan, 2016-11-21 00:59:13]

Description was changed from

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.
==========

to

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.
==========

[sullivan, 2016-11-21 00:59:13]

sullivan@chromium.org changed reviewers:
+ eyaich@chromium.org

[eyaich1, 2016-11-21 13:12:13]

lgtm

thanks for doing that!

[sullivan, 2016-11-21 14:09:02]

On 2016/11/21 13:12:13, eyaich1 wrote:
> lgtm
> 
> thanks for doing that!

(dtu is OOO so it is fine to submit w/just eyaich's review)

[ghost stip (do not use), 2016-11-21 19:46:56]

Description was changed from

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.
==========

to

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.

BUG=667435
==========

[alancutter (OOO until 2018), 2016-11-21 22:21:09]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-11-21 22:22:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 22:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 22:33:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alancutter (OOO until 2018), 2016-11-21 22:38:21]

On 2016/11/21 at 22:33:03, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Looks like eyaich needs OWNERS for this file.

[eyaich1, 2016-11-23 13:53:38]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-11-23 13:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 14:53:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479909218115310,
"parent_rev": "2726c7828636a4eb2b73a76d7a84673964bb3681", "commit_rev":
"2271bdf1d2784e8cddd5526b9787ff3452b67a44"}

[commit-bot: I haz the power, 2016-11-23 14:53:46]

Description was changed from

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.

BUG=667435
==========

to

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.

BUG=667435
==========

[commit-bot: I haz the power, 2016-11-23 14:53:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 14:57:22]

Description was changed from

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.

BUG=667435
==========

to

==========
Make generate_perf_json.py work regardless of starting working directory

This patch changes generate_perf_json.py such that you are not required
to cd into tools/perf to be able to run it.

BUG=667435

Committed: https://crrev.com/83e8ca3114f774182150be1bd2e4d85fd0b2c7ec
Cr-Commit-Position: refs/heads/master@{#434166}
==========

[commit-bot: I haz the power, 2016-11-23 14:57:23]

Patchset 2 (id:??) landed as
https://crrev.com/83e8ca3114f774182150be1bd2e4d85fd0b2c7ec
Cr-Commit-Position: refs/heads/master@{#434166}

[dtu, 2016-12-01 01:43:18]

Looks kind of hacky. The goal is to be agnostic to cwd and the fix is to
introduce cwd logic into the script?

I think the right fix would be to modify line 558.
with open('desktop_benchmark_avg_times.json') as f:

timing_file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
'desktop_benchmark_avg_times.json')
with open(timing_file_path) as f:

[alancutter (OOO until 2018), 2016-12-01 02:31:25]

On 2016/12/01 at 01:43:18, dtu wrote:
> Looks kind of hacky. The goal is to be agnostic to cwd and the fix is to
introduce cwd logic into the script?
> 
> I think the right fix would be to modify line 558.
> with open('desktop_benchmark_avg_times.json') as f:
> 
> timing_file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
'desktop_benchmark_avg_times.json')
> with open(timing_file_path) as f:

WDTY of having a src_dir() function instead?

[dtu, 2016-12-01 02:59:15]

On 2016/12/01 02:31:25, alancutter wrote:
> On 2016/12/01 at 01:43:18, dtu wrote:
> > Looks kind of hacky. The goal is to be agnostic to cwd and the fix is to
> introduce cwd logic into the script?
> > 
> > I think the right fix would be to modify line 558.
> > with open('desktop_benchmark_avg_times.json') as f:
> > 
> > timing_file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
> 'desktop_benchmark_avg_times.json')
> > with open(timing_file_path) as f:
> 
> WDTY of having a src_dir() function instead?

Sounds good :)