[debug] Add Eval scope type to inspector protocol

src/inspector/debugger-script.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
 
 /** @type {!Map<!ScopeType, string>} */
 DebuggerScript._scopeTypeNames = new Map();
 DebuggerScript._scopeTypeNames.set(ScopeType.Global, "global");
 DebuggerScript._scopeTypeNames.set(ScopeType.Local, "local");
 DebuggerScript._scopeTypeNames.set(ScopeType.With, "with");
 DebuggerScript._scopeTypeNames.set(ScopeType.Closure, "closure");
 DebuggerScript._scopeTypeNames.set(ScopeType.Catch, "catch");
 DebuggerScript._scopeTypeNames.set(ScopeType.Block, "block");
 DebuggerScript._scopeTypeNames.set(ScopeType.Script, "script");
+DebuggerScript._scopeTypeNames.set(ScopeType.Eval, "eval");
 
 /**
  * @param {function()} fun
  * @return {?Array<!Scope>}
  */
 DebuggerScript.getFunctionScopes = function(fun)
 {
     var mirror = MakeMirror(fun);
     if (!mirror.isFunction())
         return null;
@@ skipping 468 matching lines @@
  */
 DebuggerScript._buildScopeObject = function(scopeType, scopeObject)
 {
     var result;
     switch (scopeType) {
     case ScopeType.Local:
     case ScopeType.Closure:
     case ScopeType.Catch:
     case ScopeType.Block:
     case ScopeType.Script:
+    case ScopeType.Eval:
         // For transient objects we create a "persistent" copy that contains
         // the same properties.
         // Reset scope object prototype to null so that the proto properties
         // don't appear in the local scope section.
         var properties = /** @type {!ObjectMirror} */(MakeMirror(scopeObject, true /* transient */)).properties();
         // Almost always Script scope will be empty, so just filter out that noise.
         // Also drop empty Block scopes, should we get any.
         if (!properties.length && (scopeType === ScopeType.Script || scopeType === ScopeType.Block))

[kozy, 2016/11/21 17:52:09]

Dmitry, good catch! Jakob, please filter empty eval scope here.

[jgruber, 2016/11/22 13:55:21]

Done.

             break;
         result = { __proto__: null };
         for (var j = 0; j < properties.length; j++) {
             var name = properties[j].name();
             if (name.length === 0 || name.charAt(0) === ".")
                 continue; // Skip internal variables like ".arguments" and variables with empty name
             result[name] = properties[j].value_;
         }
         break;
     case ScopeType.Global:
     case ScopeType.With:
         result = scopeObject;
         break;
     }
     return result;
 }
 
 // We never resolve Mirror by its handle so to avoid memory leaks caused by Mirrors in the cache we disable it.
 ToggleMirrorCache(false);
 
 return DebuggerScript;
 })();