Issue 2519763002: Add a gitignore file for the analysis_server package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2519763002: Add a gitignore file for the analysis_server package. (Closed)

Created:
4 years, 1 month ago by devoncarew

Modified:
4 years ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a gitignore file for the analysis_server package. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f7334bef352bdbd1289f5f11fc2bf2cbf8d5d1e4

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	A	pkg/analysis_server/.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

devoncarew

Committed patchset #1 (id:1) manually as f7334bef352bdbd1289f5f11fc2bf2cbf8d5d1e4 (presubmit successful).

4 years, 1 month ago (2016-11-20 18:05:13 UTC) #5

Brian Wilkerson

4 years ago (2016-11-21 14:46:00 UTC) #6

Message was sent while issue was closed.

I don't understand the need for this. You shouldn't run pub on any of our
packages, so there shouldn't be a .packages file to ignore. There is a .packages
file in the parent directory that gives you the mapping that will be used at
run-time.

Please revert this change.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages