Add CompilationUnit indexer implementation.

Add CompilationUnit indexer implementation.

The existing index data structures were copied and adapted to the case
when every unit is indexed separately. Indexing of declarations was
removed - this information is available as unlinked.

Tests were reworked to use AnalysisDriver and made asynchronous.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f336731ed9d56379db2552c7d01cebc41ef4c330

[Paul Berry, 2016-11-21 13:46:57]

lgtm assuming `on StateError {}` is removed.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/index.dart (right):

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:53: if (element is
ConstructorElement) {
All these "is" checks look expensive.  Why not switch on `element.kind`?

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:62: element = field.getter;
Nit: IMO `element = field.getter ?? field.setter;` is cleaner.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:83: element = property.getter;
Ditto

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:221: } on StateError {}
This seems like it would cover up bugs.  Why is this necessary?

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/index_test.dart (right):

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/index_test.dart:161: //   
driver.status.lastWhere((status) {
Was this temporary debugging code?  Should it be removed?

[Brian Wilkerson, 2016-11-21 15:48:27]

lgtm

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/index.dart (right):

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:29: throw new
StateError(element.toString());
Perhaps a more informative message, such as 'Element not contained in
compilation unit: $element'?

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:146: final bool isQualified;
Perhaps document what these fields mean? It's not obvious to me what the
'offset' and 'length' are associated with.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:164: * The string to use place of
the `null` string.
"place" --> "in place"

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:189: final List<_StringInfo>
unitUnitUris = [];
Perhaps we could drop one of the "unit"s from this and the previous field.

Also, is there any correlation between the two fields? Is unitLibraryUris[i] the
uri of the library containing unitUnitUris[i]? If not, are there duplicates in
either list, or are they effectively sets? This should all be documented.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:312: _StringInfo
_getStringInfo(String str) {
"str" --> "string"

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:455: void recordSuperType(TypeName
typeName, IndexRelationKind kind) {
Document 'kind'.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:774: final bool isQualified;
Document these fields.

[scheglov, 2016-11-21 17:27:30]

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/index.dart (right):

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:53: if (element is
ConstructorElement) {
On 2016/11/21 13:46:57, Paul Berry wrote:
> All these "is" checks look expensive.  Why not switch on `element.kind`?

Done.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:62: element = field.getter;
On 2016/11/21 13:46:57, Paul Berry wrote:
> Nit: IMO `element = field.getter ?? field.setter;` is cleaner.

Done.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:83: element = property.getter;
On 2016/11/21 13:46:57, Paul Berry wrote:
> Ditto

Done.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:164: * The string to use place of
the `null` string.
On 2016/11/21 15:48:27, Brian Wilkerson wrote:
> "place" --> "in place"

Done.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:189: final List<_StringInfo>
unitUnitUris = [];
On 2016/11/21 15:48:27, Brian Wilkerson wrote:
> Perhaps we could drop one of the "unit"s from this and the previous field.
> 
> Also, is there any correlation between the two fields? Is unitLibraryUris[i]
the
> uri of the library containing unitUnitUris[i]? If not, are there duplicates in
> either list, or are they effectively sets? This should all be documented.

Done.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:221: } on StateError {}
On 2016/11/21 13:46:57, Paul Berry wrote:
> This seems like it would cover up bugs.  Why is this necessary?

Removed.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/index.dart:312: _StringInfo
_getStringInfo(String str) {
On 2016/11/21 15:48:27, Brian Wilkerson wrote:
> "str" --> "string"

Done.

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/index_test.dart (right):

https://codereview.chromium.org/2519733002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/index_test.dart:161: //   
driver.status.lastWhere((status) {
On 2016/11/21 13:46:57, Paul Berry wrote:
> Was this temporary debugging code?  Should it be removed?

Done.

[scheglov, 2016-11-21 17:28:02]

Description was changed from

==========
Add CompilationUnit indexer implementation.

The existing index data structures were copied and adapted to the case
when every unit is indexed separately. Indexing of declarations was
removed - this information is available as unlinked.

Tests were reworked to use AnalysisDriver and made asynchronous.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add CompilationUnit indexer implementation.

The existing index data structures were copied and adapted to the case
when every unit is indexed separately. Indexing of declarations was
removed - this information is available as unlinked.

Tests were reworked to use AnalysisDriver and made asynchronous.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f336731ed9d56379db2552c7d01cebc41ef4c330
==========

[scheglov, 2016-11-21 17:28:06]

Committed patchset #1 (id:1) manually as
f336731ed9d56379db2552c7d01cebc41ef4c330 (presubmit successful).