Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2519583002: Add gfx::ImageSkia and icon support to aura::PropertyConverter. (Closed)

Created:
4 years, 1 month ago by msw
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gfx::ImageSkia and icon support to aura::PropertyConverter. Split up mus app and window icon properties (like aura). Remove unused ash::mus::GetWindowAppIcon; add/update tests. BUG=663522 TEST=Automated. R=sky@chromium.org TBR=tsepez@chromium.org Committed: https://crrev.com/f84ab8b028d958dfd73d17cddb320dd319492910 Cr-Commit-Position: refs/heads/master@{#434039}

Patch Set 1 #

Patch Set 2 : Split up mus app and window icon properties. #

Patch Set 3 : Fix ConvertPropertyForTransport; add unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -79 lines) Patch
M ash/mus/property_util.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/property_util.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M ash/mus/window_manager.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/mus/property_converter.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/mus/property_converter.cc View 1 2 4 chunks +35 lines, -0 lines 0 comments Download
M ui/aura/mus/property_converter_unittest.cc View 1 2 4 chunks +47 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 4 chunks +32 lines, -27 lines 0 comments Download
M ui/views/mus/native_widget_mus_unittest.cc View 1 2 chunks +53 lines, -35 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 1 month ago (2016-11-22 19:59:36 UTC) #4
sky
LGTM
4 years, 1 month ago (2016-11-22 23:03:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519583002/40001
4 years, 1 month ago (2016-11-22 23:35:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/311032)
4 years, 1 month ago (2016-11-23 00:10:39 UTC) #13
msw
+TBR Tom for window_manager.mojom
4 years, 1 month ago (2016-11-23 00:24:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519583002/40001
4 years, 1 month ago (2016-11-23 00:25:26 UTC) #18
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-23 00:34:02 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-23 00:47:44 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 00:50:56 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f84ab8b028d958dfd73d17cddb320dd319492910
Cr-Commit-Position: refs/heads/master@{#434039}

Powered by Google App Engine
This is Rietveld 408576698