Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2519533002: Update security indicator icons on Android to match spec assets. (Closed)

Created:
4 years, 1 month ago by lgarron
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
agrieve+watch_chromium.org, chromium-reviews, maxwalker
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update security indicator icons on Android to match spec assets. BUG=666749 Committed: https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103 Cr-Commit-Position: refs/heads/master@{#433387}

Patch Set 1 #

Patch Set 2 : Optimize images. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/android/java/res/drawable-hdpi/omnibox_https_invalid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/omnibox_https_valid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/omnibox_info.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/omnibox_https_invalid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/omnibox_https_valid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/omnibox_info.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/omnibox_https_invalid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/omnibox_https_valid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/omnibox_info.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/omnibox_https_invalid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/omnibox_https_valid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/omnibox_info.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/omnibox_https_invalid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/omnibox_https_valid.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/omnibox_info.png View 1 Binary file 0 comments Download

Messages

Total messages: 12 (6 generated)
lgarron
tedchoc@, could you review?
4 years, 1 month ago (2016-11-18 19:26:49 UTC) #3
Ted C
On 2016/11/18 19:26:49, lgarron wrote: > tedchoc@, could you review? lgtm w/ some potential homework ...
4 years, 1 month ago (2016-11-18 20:04:24 UTC) #5
lgarron
On 2016/11/18 at 20:04:24, tedchoc wrote: > On 2016/11/18 19:26:49, lgarron wrote: > > tedchoc@, ...
4 years, 1 month ago (2016-11-18 20:12:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519533002/20001
4 years, 1 month ago (2016-11-19 02:35:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-19 03:22:00 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 03:23:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103
Cr-Commit-Position: refs/heads/master@{#433387}

Powered by Google App Engine
This is Rietveld 408576698