Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2519523002: Fix install-build-deps.sh --quick-check (Closed)

Created:
4 years, 1 month ago by Tom (Use chromium acct)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix install-build-deps.sh --quick-check The algorithm we were using to parse the output of dpkg-query was out of date because the format changed. This CL tries to make as little assumptions as possible about the output of dpkg-query, using the return code to determine failure instead of the output. However, we still rely on the last word of an error message being a package name, although this is only used to display which packages are missing. BUG=666937 R=mmoss@chromium.org,dpranke@chromium.org Committed: https://crrev.com/73b3a441a128d14c81bed7afc981d35f0f401f1d Cr-Commit-Position: refs/heads/master@{#433327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M build/install-build-deps.sh View 1 chunk +20 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Tom (Use chromium acct)
mmoss@: please review dpranke@: OWNERS approval
4 years, 1 month ago (2016-11-18 19:09:18 UTC) #2
Dirk Pranke
lgtm.
4 years, 1 month ago (2016-11-18 20:49:33 UTC) #3
Dirk Pranke
Oh, can you file a bug for this work, also?
4 years, 1 month ago (2016-11-18 21:11:30 UTC) #4
Tom (Use chromium acct)
On 2016/11/18 21:11:30, Dirk Pranke wrote: > Oh, can you file a bug for this ...
4 years, 1 month ago (2016-11-18 22:51:33 UTC) #6
Michael Moss
lgtm
4 years, 1 month ago (2016-11-18 22:57:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519523002/1
4 years, 1 month ago (2016-11-18 22:59:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 23:16:36 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 23:19:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73b3a441a128d14c81bed7afc981d35f0f401f1d
Cr-Commit-Position: refs/heads/master@{#433327}

Powered by Google App Engine
This is Rietveld 408576698