Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_transaction.h

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Feedback addressed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_response_info.h ('k') | net/http/http_transaction_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_transaction.h
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index eff45d10c5648d618e4366a6ea91a398b06016b1..a003d92ef88776ecc4cc35a932d61009a659e522 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -120,6 +120,8 @@ class NET_EXPORT_PRIVATE HttpTransaction {
const CompletionCallback& callback) = 0;
// Stops further caching of this request by the HTTP cache, if there is any.
+ // If there are multiple requests for this resource that are writing to the
+ // cache using SharedWriters, caching may not be stopped.
virtual void StopCaching() = 0;
// Gets the full request headers sent to the server. This is guaranteed to
« no previous file with comments | « net/http/http_response_info.h ('k') | net/http/http_transaction_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698