Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: net/http/http_response_info.h

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Feedback incorporated (Rebased till refs/heads/master@{#446065}) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_response_info.h
diff --git a/net/http/http_response_info.h b/net/http/http_response_info.h
index ab340cd4e940646f68f42abab8f35f4f4d168f8d..022479f218bc1a8008cb959f45051ac4972117ed 100644
--- a/net/http/http_response_info.h
+++ b/net/http/http_response_info.h
@@ -77,6 +77,11 @@ class NET_EXPORT HttpResponseInfo {
// The HTTP request didn't allow a conditional request. Implies !was_cached
// && network_accessed.
ENTRY_CANT_CONDITIONALIZE,
+ // Request joins the already created SharedWriters.
jkarlin 2017/02/03 18:26:20 Do we need these two new states? They don't seem c
shivanisha 2017/02/06 21:14:11 ENTRY_JOIN_SHARED_WRITING is different from ENTRY_
+ ENTRY_JOIN_SHARED_WRITING,
+ // Validation is not a match and SharedWriters exists, request dooms the
+ // shared writing entry and gets the response from the network.
+ ENTRY_DOOM_SHARED_WRITING,
jkarlin 2017/02/03 18:26:20 If you edit this enum you need to edit the enum in
shivanisha 2017/02/06 21:14:11 I cannot find the definition of HttpCache.AccessTo
ENTRY_MAX,
};

Powered by Google App Engine
This is Rietveld 408576698