Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: net/base/load_states_list.h

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Feedback incorporated (Rebased till refs/heads/master@{#446065}) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/http/http_cache.h » ('j') | net/http/http_cache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/load_states_list.h
diff --git a/net/base/load_states_list.h b/net/base/load_states_list.h
index 5e850fb622220d3b6cb02a539897032cead220f3..94b9983f0255c897b1858bbfef235f3a5a72c8f0 100644
--- a/net/base/load_states_list.h
+++ b/net/base/load_states_list.h
@@ -39,9 +39,9 @@ LOAD_STATE(WAITING_FOR_DELEGATE, 4)
// This state corresponds to a resource load that is blocked waiting for
// access to a resource in the cache. If multiple requests are made for the
-// same resource, the first request will be responsible for writing (or
-// updating) the cache entry and the second request will be deferred until
-// the first completes. This may be done to optimize for cache reuse.
+// same resource, the requests eligible for shared writing among them will be
jkarlin 2017/02/03 18:26:19 I don't know that we want to mention shared writer
shivanisha 2017/02/06 21:14:10 Sounds good.
+// responsible for writing (or updating) the cache entry and the remaining
+// requests will be deferred until the writing completes.
LOAD_STATE(WAITING_FOR_CACHE, 5)
// This state corresponds to a resource load that is blocked waiting for
« no previous file with comments | « net/BUILD.gn ('k') | net/http/http_cache.h » ('j') | net/http/http_cache.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698