Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2519433002: [ObjC ARC] Converts ios/chrome/browser/share_extension:share_extension to ARC.Automatically gener… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), mac-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/share_extension:share_extension to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/3b877dc6081cf4cf95ce35a246b6041149b6c016 Cr-Commit-Position: refs/heads/master@{#433516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ios/chrome/browser/share_extension/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/share_extension/share_extension_item_receiver.mm View 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/share_extension/share_extension_service.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
stkhapugin
PTAL. Passes downstream tests
4 years, 1 month ago (2016-11-18 18:21:38 UTC) #6
noyau (Ping after 24h)
lgtm
4 years ago (2016-11-21 10:15:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519433002/1
4 years ago (2016-11-21 10:22:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/71851)
4 years ago (2016-11-21 11:55:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519433002/1
4 years ago (2016-11-21 12:21:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 12:59:59 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-21 13:02:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b877dc6081cf4cf95ce35a246b6041149b6c016
Cr-Commit-Position: refs/heads/master@{#433516}

Powered by Google App Engine
This is Rietveld 408576698