Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2519423002: Remove unwanted <webview> border in OOPIF mode. (Closed)

Created:
4 years, 1 month ago by avallee
Modified:
4 years, 1 month ago
Reviewers:
wjmaclean
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unwanted <webview> border in OOPIF mode. This has been around for quite a white. Set the shadow iframe border to 0. BUG=667706 Committed: https://crrev.com/c7f6481c802488892776672589f32ab5f39b57e7 Cr-Commit-Position: refs/heads/master@{#433871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M extensions/renderer/resources/guest_view/guest_view_iframe_container.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
avallee
I always noted this with OOPIF webview but it turned out to be super easy ...
4 years, 1 month ago (2016-11-22 15:32:19 UTC) #4
wjmaclean
On 2016/11/22 15:32:19, avallee wrote: > I always noted this with OOPIF webview but it ...
4 years, 1 month ago (2016-11-22 15:39:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519423002/1
4 years, 1 month ago (2016-11-22 15:44:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 15:48:36 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 15:52:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7f6481c802488892776672589f32ab5f39b57e7
Cr-Commit-Position: refs/heads/master@{#433871}

Powered by Google App Engine
This is Rietveld 408576698