third_party/WebKit/Source/bindings/core/v8/Dictionary.h - Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.h

Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception. (Closed)

Patch Set: Addressed review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.h b/third_party/WebKit/Source/bindings/core/v8/Dictionary.h

index 3b19d730a3d7f40a78f3fc9f0a3f64db5469e86f..1f182cf9bca1750304db864f7342037d67c98dc9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.h

+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.h

@@ -78,8 +78,9 @@ class CORE_EXPORT Dictionary final {

}

bool get(const StringView& key, Dictionary&) const;

- bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;

- bool getPropertyNames(Vector<String>&) const;

+ HashMap<String, String> getOwnPropertiesAsStringHashMap(

+ ExceptionState&) const;

+ Vector<String> getPropertyNames(ExceptionState&) const;

bool hasProperty(const StringView& key, ExceptionState&) const;

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp » ('j') | no next file with comments »