Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception. (Closed)
Patch Set: Addressed review comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // TODO(guidou): close() should never throw an exception. 88 // TODO(guidou): close() should never throw an exception.
89 [RaisesException] void close(); 89 [RaisesException] void close();
90 attribute EventHandler onnegotiationneeded; 90 attribute EventHandler onnegotiationneeded;
91 attribute EventHandler onicecandidate; 91 attribute EventHandler onicecandidate;
92 attribute EventHandler onsignalingstatechange; 92 attribute EventHandler onsignalingstatechange;
93 attribute EventHandler oniceconnectionstatechange; 93 attribute EventHandler oniceconnectionstatechange;
94 // attribute EventHandler onicegatheringstatechange; 94 // attribute EventHandler onicegatheringstatechange;
95 95
96 // https://w3c.github.io/webrtc-pc/#legacy-interface-extensions 96 // https://w3c.github.io/webrtc-pc/#legacy-interface-extensions
97 // These methods return Promise<void> because having Promise-based versions requires that all overloads return Promises. 97 // These methods return Promise<void> because having Promise-based versions requires that all overloads return Promises.
98 [CallWith=ScriptState] Promise<void> createOffer(RTCSessionDescriptionCallba ck successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dic tionary rtcOfferOptions); 98 [CallWith=ScriptState, RaisesException] Promise<void> createOffer(RTCSession DescriptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallb ack, optional Dictionary rtcOfferOptions);
99 // TODO(guidou): There should be no mediaConstraints argument. 99 // TODO(guidou): There should be no mediaConstraints argument.
100 [CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallb ack successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Di ctionary mediaConstraints); 100 [CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallb ack successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Di ctionary mediaConstraints);
101 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description, VoidCallback successCallback, [Default=Undefined] optional R TCPeerConnectionErrorCallback failureCallback); 101 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description, VoidCallback successCallback, [Default=Undefined] optional R TCPeerConnectionErrorCallback failureCallback);
102 // TODO(guidou): The failureCallback argument should be non-optional. 102 // TODO(guidou): The failureCallback argument should be non-optional.
103 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback); 103 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);
104 [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Pro mise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, V oidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback); 104 [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Pro mise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, V oidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback);
105 105
106 // TODO(guidou): The selector argument should the first (nullable, 106 // TODO(guidou): The selector argument should the first (nullable,
107 // non-optional) argument, and there should be a third failureCallback 107 // non-optional) argument, and there should be a third failureCallback
108 // argument. 108 // argument.
(...skipping 14 matching lines...) Expand all
123 [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optiona l RTCConfiguration configuration, optional Dictionary mediaConstraints); 123 [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optiona l RTCConfiguration configuration, optional Dictionary mediaConstraints);
124 [Measure] sequence<MediaStream> getLocalStreams(); 124 [Measure] sequence<MediaStream> getLocalStreams();
125 [Measure] sequence<MediaStream> getRemoteStreams(); 125 [Measure] sequence<MediaStream> getRemoteStreams();
126 [Measure] MediaStream getStreamById(DOMString streamId); 126 [Measure] MediaStream getStreamById(DOMString streamId);
127 [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaSt ream? stream, optional Dictionary mediaConstraints); 127 [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaSt ream? stream, optional Dictionary mediaConstraints);
128 [Measure, RaisesException] void removeStream(MediaStream? stream); 128 [Measure, RaisesException] void removeStream(MediaStream? stream);
129 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack); 129 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack);
130 attribute EventHandler onaddstream; 130 attribute EventHandler onaddstream;
131 attribute EventHandler onremovestream; 131 attribute EventHandler onremovestream;
132 }; 132 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698